voodoo47 on 3/3/2019 at 15:30
very quick look, and looking ok so far. some stuff:
- the "do you want to update old data" prompt is unnecessary, as the answer is simply yes (I do want all files up to date so my game would not glitch out)
- crop movies properly
Code:
movie_crop_exclude credits.avi+success.avi+death.avi+B01.avi+b02.avi+B04.avi+B05.AVI+B06.avi+B07.avi+b08.avi+b09.avi+b10.avi+b11.avi+B12.avi+B13.avi+b14.avi+b15.avi
- currently, vanilla resources (missions, if nothing else) are overwritten when fixed ones are installed, maybe consider installing them separately, TafferPatcher style (patchedmis/patchedres)
- enable FSAA by default (multisampletype 8)
- enable ATOC by default (d3d_disp_enable_atoc 1)
- the carrybody mod in cam_mod ini should probably have a higher priority, right after the candles should be good
- outdated gamesys.dml, update to prevent sorting issues on very large trees;
Code:
DML1
//adding proper alpha to avoid sharp edges on plants
ObjProp -3291 "RenderAlpha" = 0.9999
ObjProp -3292 "RenderAlpha" = 0.9999
ObjProp -3293 "RenderAlpha" = 0.9999
ObjProp -2840 "RenderAlpha" = 0.9999
ObjProp -2841 "RenderAlpha" = 0.9999
ObjProp -5345 "RenderAlpha" = 0.9999
ObjProp -5346 "RenderAlpha" = 0.9999
ObjProp -6079 "RenderAlpha" = 0.9999
//adding proper alpha to avoid sharp edges on blood stains
+ObjProp -1519 "RenderAlpha" = 0.9999
//fixing hammer dimensions
+ObjProp -458 "PhysDims"
{
"Radius 1" 0.34
}
also, are these resources in?
-the (
https://www.systemshock.org/index.php?topic=7633.0) vhotted candle pack (no reason to not have it there, vhots may come in handy and some models had flaws that have been fixed as well. new need to be installed when EP or NecroAge is active, old when not - so basically, the "old" set should be included with the fixed resources, "new" with EP, and the "obj" folder needs to be removed from the Candles mod. this is something that will probably need more testing - making sure all combinations of mods work without issues).
-the (
https://www.systemshock.org/index.php?topic=6021.msg75632#msg75632) jointed bell (now swings around. rename the model to bell2.bin for T2).
-the (
https://www.systemshock.org/index.php?topic=6021.msg87193#msg87193) retextured wooden ladders (all the ladders.zip - vertical bars are now textured properly).
Jax64 on 3/3/2019 at 20:29
Quote Posted by voodoo47
- the "do you want to update old data" prompt is unnecessary, as the answer is simply yes (I do want all files up to date so my game would not glitch out)
Duly noted. Critical files such as dark.gam and the first party scripts are installed regardless of selection; only updated missions and resources are installed as a result of the option. It was intended to give the user a choice(mostly between the 1.07 and 1.18 versions of the missions), but I suppose having the data around would only cause problems.
Quote:
- crop movies properly
...
- enable FSAA by default (multisampletype 8)
- enable ATOC by default (d3d_disp_enable_atoc 1)
- the carrybody mod in cam_mod ini should probably have a higher priority, right after the candles should be good
- outdated gamesys.dml, update to prevent sorting issues on very large trees;
All of these are now integrated. As for the anti-aliasing options, the above is set by default, but other preset options are available if the default proves to be too much for the user's system or the user has a powerful system and wants more graphical fidelity.
Quote:
- currently, vanilla resources (missions, if nothing else) are overwritten when fixed ones are installed, maybe consider installing them separately, TafferPatcher style (patchedmis/patchedres)
If the fixed missions are detected, vanilla missions are reinstalled if the user runs setup while not selecting the fixed missions pack. So the user can choose whether they want or do not want the fixed missions with each run of the patcher. This method saves space and doesn't clutter the installation with two sets of missions. Fixed resources behave the same way, but do not overwrite existing resources when installed. Rather, they are loaded prior to vanilla resources in the ".\RES\RESPATCH" directory.
Everything was in besides the jointed bell, which is now integrated. Thank you very much for taking a look, as it has already been quite beneficial.
voodoo47 on 3/3/2019 at 20:48
sounds good - feel free to drop the next beta on me, I'll give it another spin.
note that no 1.07 stuff should be left/allowed under no circumstances, imho.
Jax64 on 4/3/2019 at 03:49
Absolutely. I uploaded the newest version and the link I sent you previously should now direct you to it.
And yes, it is probably best practice to simply update to the latest official version automatically, which is the current behavior. It makes sense to present the user with options while at the same time not sacrificing usability.
voodoo47 on 4/3/2019 at 08:10
getting smoother. the 1.18 patch crfs are merged with the patched resources, I'd assume? also, NVScript seems to be out of date for quite a bit, get the latest version (
https://nameless.zanity.net/nvscriptbeta/thief2/NVScript.zip) here (maybe double check all the other 3rdparty scripts as well).
also watch out - the new bell2 is a hires (EP) resource, so it needs to be placed into the EP crf, RESPATCH should be reserved for fixed vanilla resources.
Jax64 on 4/3/2019 at 17:23
Quote Posted by voodoo47
the 1.18 patch crfs are merged with the patched resources, I'd assume?
Actually, the current implementation involves patching the original CRFs if version 1.07 is detected. If 1.18 is detected, they are not patched. I suppose merging them with with the fixed resources would be another implementation, but it would also mean that they would be present regardless of game version, making them redundant on 1.18 installs.
Ah, I was using NVScript 1.26 from (
https://www.ttlg.com/forums/showthread.php?t=134166) here. It is good to know that there is a repository where newer versions may be obtained. I will use the one from that location from now on.
Quote:
the new bell2 is a hires (EP) resource, so it needs to be placed into the EP crf, RESPATCH should be reserved for fixed vanilla resources.
Yes, this was my mistake. It has since been corrected in the latest build, which is now uploaded in the same fashion as before.
EDIT: With the current candles implementation, wouldn't the vhotted objects be nullified by either NecroAge or EP2 if installed? The current load order has both of these supercede the fixed resources and EP.
voodoo47 on 4/3/2019 at 17:44
not sure whether there ever was something like an out of the box 1.18 version that would have the patch crfs already merged into the main crfs (I only have the sold out version and the platinum dvd, both are the dreaded 1.07/1.18 hybrid version, same goes for steam). well, as long as the patcher always makes sure the 1.18 files are loaded properly, everything should be fine.
yes, NecroAge and EP2 would create problems for the Candle mod unless they include proper models, that's why I'm trying to get them updated. TFix is installing some annoying overrides to circumvent the issue until it's resolved properly - I'm hoping to get both packs updated soon enough so you won't have to deal with this in a similar fashion. having the models inside the Candle mod folder would also circumvent the problem, but then users wouldn't be able to choose whether they want to use vanilla style candles ("old") or hires ones ("new"), and would have to roll with whatever set is there, and that is a guaranteed way of getting complaints (been there).
Jax64 on 4/3/2019 at 18:24
I happen to have two trapezoidal-box Thief 2 releases. One is version 1.07 and the other 1.18, making it very easy to compare versions. The 1.18 release appears to have the updated resources integrated into the CRFs and updated versions of both gen.osm and dark.gam, which are the two files the patcher checks for to determine the version. These "hybrid" installs have the 1.07 version of these two files, flagging them to be patched properly. This implementation seems to work rather well, as it properly updates both version 1.07 and the hybrid versions.
As for the candle mod situation, I appreciate the effort to circumvent this issue. Hopefully they can be updated to include proper support, but the current implementation should work well enough until then.
voodoo47 on 4/3/2019 at 18:42
we'll see - if they won't get updated (EP2 is looking good, and I've just sent a pm to the NecroAge author), the vhotted candle models will either have to be returned into the Candles modfolder (forcing everyone to use the hires models for CanStic2.bin, CanStick.bin and TrCandle.bin), or create TFix style overrides, which isn't terrible, but I always prefer a proper solution wherever possible.
looks like you've got the whole 1.07/1.18 situation under control, so not going to poke into that any further.
Jax64 on 9/3/2019 at 06:51
Quote Posted by voodoo47
we'll see - if they won't get updated (EP2 is looking good, and I've just sent a pm to the NecroAge author), the vhotted candle models will either have to be returned into the Candles modfolder (forcing everyone to use the hires models for CanStic2.bin, CanStick.bin and TrCandle.bin), or create TFix style overrides, which isn't terrible, but I always prefer a proper solution wherever possible.
I seem to have found a solution to this problem, which should work fairly well even if the mods are not updated soon. The patcher will now place the high-resolution models in the candles mod folder only if either NecroAge or EP2 is detected. If they are not, no action is taken, allowing the models from either the EP or the fixed resources to be used depending on what is chosen during installation. The only drawback to this method is the fact that the user must run the patcher after installing NecroAge or EP2, meaning he must run it again if the mods were installed after the initial patching.
In addition to this, I have added the option to install legacy executables that do not interfere with the rest of the install, very similar to TFix. I do not know if this particularly interests anybody, but perhaps the option for some sort of compatibility in case of failure would be welcome.
Though with all of this out of the way, it may be nearing time for the first release. I do intend to make further changes, but the state T2Fix is now is fairly stable and full-featured, and it would be nice to have an easy way of updating in the future, especially for the upcoming contest.