Krellek's Labyrinth 1.1 (update)

Ziemanskye on 18/10/2005 at 11:29

Quote Posted by potterr

Ziemanskye, teh user.ini file is only updated when you click PLAY in GL for a theif 3 FM.

Even going all the way into the mission, the user.ini isn't changing at all.

I don't know if the dates are important on the files, but my user.ini hasn't had it's date changed since 26th september (which implies the date at least wasn't changing for DarkDragon's level either- but I don't think it needed changed for that)

potterr on 18/10/2005 at 16:59

Ok here is what happens with regards to the user.in file (code included)

first off the restore the GLBU version (note the code displayed is missing the occasional "\" and displaying "" instead, this is due to the forum display rather than the code itself).

Code:

Public Sub Restore_T3_INI_files()
If t3_game_location = "" Then Exit Sub
Set fs = CreateObject("Scripting.FileSystemObject")
On Error Resume Next
myIniListArray = Split("default,FacialExp,MotionTags,reverbstyles,T3AutoTag,T3Camera,T3Hud,T3InputMem,T3ItemGrid,T3Menu,T3PhysicsSound,T3PlayerAnims,T3Rumble,T3UI,T3UILights,T3UISoup", ",")
If fs.FileExists(Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini.GLBU") Then
Call fs.deletefile(Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini", True)
Sleep (200)
Call fs.movefile(Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini.GLBU", Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini")
End If

For arra = 0 To UBound(myIniListArray)
If fs.FileExists(t3_game_location & "\" & myIniListArray(arra) & ".ini.GLBU") Then
Call fs.deletefile(Replace(t3_game_location, "\System", "") & "\" & myIniListArray(arra) & ".ini", True)
Sleep (200)
Call fs.movefile(t3_game_location & "\" & myIniListArray(arra) & ".ini.GLBU", t3_game_location & "\" & myIniListArray(arra) & ".ini")
End If
Next
Set fs = Nothing
End Sub

The important part here is If fs.FileExists(Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini.GLBU") Then
as what this is doing is to say does the user.ini.glbu file exist in (for example my game path) d:\thief3\user.ini.glbu, if so rename it to be user.ini (note that the System folder is being knocked off the end of the game path, and teh game path is that of the T3GAME in teh garrettloader.ini file).
Ziemanskye, this would explain the 26th sept date as your original user.ini file is never touched, just the copied version and so the date never changes (changing teh file name does not change the modified date).

Ok next we have the actual work done to see if there is a need to update the user.ini file.

Code:

Public Sub Check_For_new_T3_INI_files()
If t3_game_location = "" Then Exit Sub
myIniListArray = Split("default,FacialExp,MotionTags,reverbstyles,T3AutoTag,T3Camera,T3Hud,T3InputMem,T3ItemGrid,T3Menu,T3PhysicsSound,T3PlayerAnims,T3Rumble,T3UI,T3UILights,T3UISoup", ",")
Set fs = CreateObject("Scripting.FileSystemObject")
If fs.FileExists(Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user_patch.ini") Then
mycopy = fs.copyfile(Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini", Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini.GLBU")
Call Update_T3_ini_files(Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user.ini", Replace(Replace(t3_game_location, "\System", ""), "\system", "") & "\user_patch.ini")
End If

For arra = 0 To UBound(myIniListArray)
If fs.FileExists(t3_game_location & "\" & myIniListArray(arra) & "_patch.ini") Then
mycopy = fs.copyfile(t3_game_location & "\" & myIniListArray(arra) & ".ini", t3_game_location & "\" & myIniListArray(arra) & ".ini.GLBU")
Call Update_T3_ini_files(t3_game_location & "\" & myIniListArray(arra) & ".ini", t3_game_location & "\" & myIniListArray(arra) & "_patch.ini")
End If
Next
Set fs = Nothing
End Sub

now if you are getting a user.ini.glbu file being made (delete your user.ini and rename your user.ini.glbu file to user.ini and click the PLAY button in GL for K.L. again and see if you get one created) then the following function should be run.

Code:

Public Sub Update_T3_ini_files(INI_File_Location As String, Custom_File_Name As String)
Dim ini_lists(50, 100) As String
Dim Current_ini_line As Integer, Current_ini_section As Integer
Current_ini_line = -1
Current_ini_section = 0
'get all ini file sections
Open Custom_File_Name For Input As #22
Do Until EOF(22) = True
If LOF(22) = 0 Then Exit Do
Line Input #22, myline
If Left(Trim(myline), 1) = "[" Then
'getting title section
Current_ini_line = Current_ini_line + 1
ini_lists(Current_ini_line, 0) = Replace(Replace(myline, "[", ""), ]", "")
Current_ini_section = 1
ElseIf Left(Trim(myline), 1) <> ";" And Len(Trim(myline)) <> 0 Then
'getting subsections
If ini_lists(Current_ini_line, 0) <> "" Then
ini_lists(Current_ini_line, Current_ini_section) = Trim(Left(myline, InStr(1, myline, "=", vbTextCompare) - 1))
Current_ini_section = Current_ini_section + 1
End If
End If
Loop
Close #22
'now edit each ini file section
Dim myOrigInITemp As String
Dim myNewInITemp As String
For i = 0 To UBound(ini_lists)
If ini_lists(i, 0) = "" Then Exit For
For w = 1 To UBound(ini_lists)
If ini_lists(i, w) = "" Then Exit For
myOrigInITemp = Trim(GetINI(INI_File_Location, ini_lists(i, 0), ini_lists(i, w), "0"))
myNewInITemp = (GetINI(Custom_File_Name, ini_lists(i, 0), ini_lists(i, w), "0"))
If myNewInITemp <> myOrigInITemp Then
myret = SetINI(INI_File_Location, ini_lists(i, 0), ini_lists(i, w), myNewInITemp)
End If
Next
Next
End Sub

This function currently handles up to 50 sections with 100 items in each (Dim ini_lists(50, 100) As String) (although I have concerns that in future this may not be sufficent).
Basically what its doing is opening up the user_patch.ini file, scanning the contents for each section header (the ones in the square brackets), adding them to the first value of the ini_lists variable. Then it scans down until either the end of the file or it finds another section and adds each item found to the second value of the ini_lists variable (under the first values section...see *** below). Having stepped through it countless times I can't see any problems with it unless the file does not exist.
What I would like to do is to test a debug version of GL 1.22 on a few people with this issue and see where the problem is occuring.

*** For those that don't know arrays, the ini_lists variable has two parts, 50 values and 100 values, this means that when a value is added to ini_lists(0,0) it adds it to the first 0, in corrispondence to the second 0 (this will be the section title), now when something is added to ini_lists(0,1) this will be under the first section title (0) but will be the first item, and so on (ini_lists(1,0) will be the title of section 2 in the user.ini file, etc).

Ziemanskye on 18/10/2005 at 17:11

eeeep

potterr on 18/10/2005 at 17:15

Ziemanskye, thats ok, its not the tidiest of code at the moment, I was going to tidy it up and reduce it once I was sure it all worked.
Effecitvely though if the files exist where there should do and they are not read only then the process should work fine.

GlasWolf on 18/10/2005 at 18:49

What I'm seeing at the moment (using 1.21) is ok until the uninstall point. Starting with the default user.ini, the glbu file is created ok and the ini updated correctly (using KL 1.0). When I restore the OMs, the user.ini isn't restored to its original state, so future FMs will inherit any settings they don't specifically overwrite. This is different to what others are seeing obviously, but will also cause problems in the long run.

For those with user.inis that aren't being updated at all, maybe there's a PC config issue. Are you logged in as admin users? Any funny permissions on your ini files/dirs? What's your T3 path? Yes/no/c:\Program Files\Thief3 for me.

Brainstorming: I wonder if the update function is being called (the presence of the .glbu file suggests it's entering the loop, but I'd try deleting the user.ini, renaming the user.ini.glbu to user.ini and retrying to confirm, also maybe a log entry in a debug build). Also the EOF/LOF checks would abort the proc if they were incorrect - maybe the passed variables could be wrong? Again that could be a path thing.

potterr on 18/10/2005 at 19:06

Just to correct GW there, don't delete the user.ini.GLBI file, delete the user.ini and rename the user.ini.GLBU file to be user.ini.
The user.ini.GLBU file should effectively be your original version, the user.ini if you have a user.ini.glbu file will be a copied version used for editing.

Version 1.22 has a debug log created for the ini file pass through, this will help diagnose any future problems. I am also currently adding a few more diagnostic bits in as well so that it will make bug fixing easier.

GlasWolf on 18/10/2005 at 19:18

Thanks p, edited in case anyone jumps in there.

The test version exhibits the same behaviour as I described above, btw.

potterr on 18/10/2005 at 19:34

Ok, I want 5 people that have experienced either the user.ini not being updated for KL or GL giving an ADODC error to PM me please with their GL version number. Only do this if you are willing to test a beta of GL and if you are able to do so tonight...

With regards to the user.ini not being restored for the original missions, sorry oversite on my part there, I'll fix that now.

Hopefully we will be able to get everyone playing this FM by the end of the week.

Bardic on 19/10/2005 at 01:34

I'm not sure if this is a bug or if I haven't finished a certain goal yet, but I can't frob the door.

[SPOILER]
I have put out the fires and destroyed the plant. I walked into the room with the mages and they disappeared. I frobbed the painting and ran into the hallway behind the portals, but the secret door in the longest hallway won't light up or open. Is there something else I need?

Goals not yet done are:
Find what Krellek has done with the Mages
Release the 3 corners of Magick
90% Loot
Leave the Castle
[/SPOILER]

But a great mission. I've been at it for maybe 6-7 hours now ghosting it. Noisy floors.

nomad of the pacific on 19/10/2005 at 01:47

Ascottk, I just had a look at the user_patch.ini files in version .8 and 1.0 and they both have "DynamicVertexPool0=7077888". If anyone is having problems running Labyrinth, maybe fixing that line by taking out the "0" might help.