Mortal Monkey on 23/11/2005 at 18:55
Cool. From now on I'll be known as just ****.
I knew that, I was just giving an example FS >:|
what about about "<img src="fuckinhugeimglol.gif" />"?
David on 23/11/2005 at 20:47
The < character has been censored in new usernames since it became apparent it was causing a problem.
Vigil on 23/11/2005 at 21:08
Um.
Why not just run the usernames through <code><a href="http://fi.php.net/manual/en/function.htmlspecialchars.php">htmlspecialchars()</a></code> before they're printed out into the originally-posted-by line? That's what the function is
for, and that's what the templates should have been doing all along (I expect every other template does it, otherwise <username> would be missing in a lot more places). That way people get to keep their silly angle quotes in usernames and everybody's happy.
PS: The reason why having the (unencoded) <username> in was fucking up the formatting is because browsers treat <username> as the opening of a "username" tag. There is no corresponding closing </username> tag, so the element <username> is inside (the 'originally posted by' line) is treated as never having been closed. How browsers react to this depends on their parser, but none of them can cope gracefully with it.
Edit: lol incomplete sentencetastic
SubJeff on 23/11/2005 at 21:39
script'd :p
ZylonBane on 23/11/2005 at 21:41
That would also need to be added somewhere in the search module. Try typing <Username> into the user search field, wait a moment, and lol at the tiny empty box that pops up.
Come to think of it, let's just ban <Username>. ;)
David on 23/11/2005 at 23:40
Quote Posted by Vigil
Um.
Why not just run the usernames through htmlspecialchars() before they're printed out into the originally-posted-by line?
Because I'm on holiday and I don't wish to waste the time tossing about fixing a trivial issue that can wait.
d0om on 25/11/2005 at 14:17
I am disapointed. I thought it was about Angel brackets.
D'Juhn Keep on 27/11/2005 at 05:53
You're disappointed? After my incredible picture?!
What's a guy gotta do around here. :(
Paz on 27/11/2005 at 13:44
The sand is leaking in through the window!
RUN DAVE, RUN!
(I guess the sun being in the corner of the room is a more pressing issue, but hey)
