FenPhoenix on 13/12/2020 at 03:27
What version did you update from?
Could you post or link:
-A screenshot of the main window showing the duplicate listings, making sure to show all the columns especially the Archive column
-Your FMData.ini file
-Your Config.ini file
(located in AngelLoader\Data)
FenPhoenix on 13/12/2020 at 04:39
I can't access them - can you make them public?
Stingm on 13/12/2020 at 04:48
I made you a viewer. If thats not right just tell me what to do to make it public.
Edit: Just replied to all requests and gave access I think.
FenPhoenix on 13/12/2020 at 05:28
Alright, so first thing, 1.4.6 didn't change anything from 1.4.5 except removing one length check where an FM name gets passed to the game right before it plays it (no changes to the FM finder, scanner, displayer, or anything else), so I'm guessing you either did something besides just upgrade, or maybe the duplication started with 1.4.5 but you didn't notice until 1.4.6?
Looking at Hush, Hush Sweet Harlot in the data file, I can see there are two entries where they both have the same archive name but one of them has the InstalledDir of "HushHush,SweetHarlot_ENG" and the other "HushHush_SweetHarlot_ENG" (note the first comma is an underscore here). That suggests to me you may have imported data from NewDarkLoader at some point. If that's the case then I guess there's a bug somewhere in the handling of the different InstalledDir values that get imported from different loaders (not surprising, keeping it all sorted out is nightmarish).
I have a guess as to what may be happening here though. My guess is that this problem started with 1.4.5 because there was a bugfix where it used to be if you had cool_mission.zip and cool_mission.7z in the same folder, it would throw an error, but now it allows it (which is correct), and there were also a couple other performance-related changes in the same code file. That part of the code is supposed to cull out duplicate entries, but apparently something about it broke that my testing didn't catch. Now that I know what to test for, I'll go through it and suss out what the problem is.
Stingm on 13/12/2020 at 07:16
Hey the test worked. The double entries are gone. Thanks a bunch.
I promise all I did was upgrade. I wouldn't even know what else to do.
I did import notes etc from newdarkloader a long time ago with your help. As for 1.45 it is possible that I didn't notice it then. I'm just glad you fixed it. Thanks again!
FenPhoenix on 13/12/2020 at 10:27
Cool. Then...
(
https://fenphoenix.com/apps/AngelLoader/AngelLoader_v1.4.7.zip)
AngelLoader v1.4.7 is out.
Fixed:In certain situations, there could be multiple copies of a given FM displayed. This fix is really just papering over a more fundamental problem where we're required to ID an FM by its "installed name", but installed names can be different depending on if AL, FMSel, or NDL created the installed name. But it now works as before at least.
caqo on 23/12/2020 at 20:20
Fen,
Here is the Spanish Translation ini file updated to 1.4.7:
(
https://drive.google.com/file/d/1Iqxqa5pwveTxnUExTapfyT4VsZ4YNeTT/view?usp=sharing) https://drive.google.com/file/d/1Iqxqa5pwveTxnUExTapfyT4VsZ4YNeTT/view?usp=sharing
And I have to report a little bug: Program is not displaying translated data for [MainMenu] and [AboutWindow] sections, it shows on english only, despite the text I change.
FenPhoenix on 23/12/2020 at 20:55
Thanks for the translation.
The bug is that the "[MainMenu]", "[AboutWindow]", and "[GameVersionsWindow]" headers have a space at the end in your Spanish.ini file (ie. "[MainMenu] ") and AngelLoader is failing to account for that when it reads them. I'll remove the spaces before uploading this new Spanish.ini file and I'll make AngelLoader ignore surrounding spaces on headers for the next version.
Thanks for the help :)